Dualshock all day. That and the SNES controller are perfect, specifically SNES for its era. I've never been a fan of Xbox controllers and hate their d-pads. I guess the Xbone controller is fine, but never used it myself.
But for me, Dualshock wins just for the longevity and it's ease of use for multiple styles of games.